AMLB-specific test case added #1274

nicl-nno · 2024-03-13T10:48:35Z

Error "IndexError: arrays used as indices must be of integer (or boolean) type" is found if final pipeline contains "resample" op

docu-mentor · 2024-03-13T10:48:38Z

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

open-code-helper · 2024-03-13T10:48:39Z

👋 Hi, I'm @open-code-helper, an LLM-powered GitHub app
powered by NVIDIA AI Foundation Models and Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@open-code-helper run

and I will start my analysis. I only look at what you changed
in this PR.

github-actions · 2024-03-13T10:49:40Z

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

codecov · 2024-03-13T10:56:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.95%. Comparing base (cd915a8) to head (c18a80f).
Report is 6 commits behind head on master.

❗ Current head c18a80f differs from pull request most recent head 773ff88. Consider uploading reports for the commit 773ff88 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
+ Coverage   79.88%   79.95%   +0.07%     
==========================================
  Files         146      146              
  Lines       10065    10051      -14     
==========================================
- Hits         8040     8036       -4     
+ Misses       2025     2015      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pep8speaks · 2024-04-01T16:36:25Z

Hello @nicl-nno! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-04-15 20:49:57 UTC

Lopa10ko

не очень понимаю, как этот PR связан с #1273
исправления в get_metrics не должны были повлиять на IndexError в AMLB интеграционнике

по поводу AMLB-specific теста:
верно ли понимаю, что проблема пока регистрируется только на пайплайнах с нодой resample?
наверное, стоит преобразовать np.ndarray в InputData и с уже верными индексами (пусть даже idx=np.arange(len(x_train)) скормить пайплайну на resample.

test/unit/api/test_main_api.py

test/integration/api/test_main_api.py

fedot/api/main.py

Lopa10ko · 2024-04-02T15:08:10Z

test/integration/api/test_main_api.py

+
+@pytest.mark.parametrize('initial_assumption, timeout',
+                         [(resample_pipeline, 0.001),
+                          (None, 5.0)


не очень понятна идея, для чего здесь implicit initial_assumption=None?
будет NoneType object is not subscriptable где-то при попытке логировать

DRMPN · 2024-04-10T13:25:37Z

/fix-pep8

prepare test data again

tests that get_metrics works correctly when target is defined as a string and test_data doesn't contain it

Co-authored-by: George Lopatenko <81328772+Lopa10ko@users.noreply.github.com>

DRMPN · 2024-04-11T11:49:22Z

✅ Integration run - https://github.com/aimclub/FEDOT/actions/runs/8644854445

Update fedot/api/main.py Co-authored-by: George Lopatenko <81328772+Lopa10ko@users.noreply.github.com>

DRMPN · 2024-04-15T20:48:49Z

/fix-pep8

DRMPN · 2024-04-15T20:49:19Z

✅ Integration run - https://github.com/aimclub/FEDOT/actions/runs/8695868602

docu-mentor · 2024-05-07T14:35:52Z

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

nicl-nno mentioned this pull request Mar 13, 2024

[Bug]: Invalid fitness after objective evaluation. Skipping the graph: (/n_scaling;)/n_rf_{'n_jobs':32} #1273

Open

nicl-nno assigned DRMPN Mar 25, 2024

DRMPN linked an issue Apr 1, 2024 that may be closed by this pull request

[Bug]: Invalid fitness after objective evaluation. Skipping the graph: (/n_scaling;)/n_rf_{'n_jobs':32} #1273

Open

nicl-nno requested review from Lopa10ko and RomanKharkovskoy April 2, 2024 09:39

Lopa10ko reviewed Apr 2, 2024

View reviewed changes

DRMPN force-pushed the amlb-fixes branch from 6851860 to c18a80f Compare April 4, 2024 08:53

nicl-nno and others added 15 commits April 11, 2024 12:52

AMLB-specific test case added

1f1f205

main.py get_metrics prepare test data again

d6b413c

prepare test data again

add constraint when test_data target is empty

5c9d0ca

update constraint for np.ndarray and pd.Series

ce5747f

add test for get_metrics

0a3cacb

tests that get_metrics works correctly when target is defined as a string and test_data doesn't contain it

Update test_main_api.py

9e25416

change predict_proba to predict

5c12bfa

Update test_main_api.py

232a811

update test case

cc4a568

rewrite test function

d214aec

fix inconsistent numbers of samples

83603ea

make drop inplace to trigger bug

9a28083

try to fix amlb specific problem

3facc3a

Automated autopep8 fixes

79dbec8

Apply suggestions from code review

e503ef0

Co-authored-by: George Lopatenko <81328772+Lopa10ko@users.noreply.github.com>

DRMPN force-pushed the amlb-fixes branch from e4968d8 to e503ef0 Compare April 14, 2024 22:41

DRMPN and others added 2 commits April 15, 2024 16:02

Apply suggestions from code review

4d91255

Update fedot/api/main.py Co-authored-by: George Lopatenko <81328772+Lopa10ko@users.noreply.github.com>

move pipeline to function's scope

9475b2a

Automated autopep8 fixes

773ff88

nicl-nno closed this May 7, 2024

nicl-nno reopened this May 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AMLB-specific test case added #1274

AMLB-specific test case added #1274

nicl-nno commented Mar 13, 2024

docu-mentor bot commented Mar 13, 2024

open-code-helper bot commented Mar 13, 2024

github-actions bot commented Mar 13, 2024 •

edited

codecov bot commented Mar 13, 2024 •

edited

pep8speaks commented Apr 1, 2024 •

edited

Lopa10ko left a comment •

edited

Lopa10ko Apr 2, 2024

DRMPN commented Apr 10, 2024

DRMPN commented Apr 11, 2024 •

edited

DRMPN commented Apr 15, 2024

DRMPN commented Apr 15, 2024 •

edited

docu-mentor bot commented May 7, 2024

AMLB-specific test case added #1274

Are you sure you want to change the base?

AMLB-specific test case added #1274

Conversation

nicl-nno commented Mar 13, 2024

docu-mentor bot commented Mar 13, 2024

open-code-helper bot commented Mar 13, 2024

github-actions bot commented Mar 13, 2024 • edited

Comment last updated at

codecov bot commented Mar 13, 2024 • edited

Codecov Report

pep8speaks commented Apr 1, 2024 • edited

Comment last updated at 2024-04-15 20:49:57 UTC

Lopa10ko left a comment • edited

Choose a reason for hiding this comment

Lopa10ko Apr 2, 2024

Choose a reason for hiding this comment

DRMPN commented Apr 10, 2024

DRMPN commented Apr 11, 2024 • edited

DRMPN commented Apr 15, 2024

DRMPN commented Apr 15, 2024 • edited

docu-mentor bot commented May 7, 2024

github-actions bot commented Mar 13, 2024 •

edited

codecov bot commented Mar 13, 2024 •

edited

pep8speaks commented Apr 1, 2024 •

edited

Lopa10ko left a comment •

edited

DRMPN commented Apr 11, 2024 •

edited

DRMPN commented Apr 15, 2024 •

edited