Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Root DOM blocks other elements in popup mode #20

Open
caaatisgood opened this issue Sep 6, 2018 · 6 comments
Open

Root DOM blocks other elements in popup mode #20

caaatisgood opened this issue Sep 6, 2018 · 6 comments

Comments

@caaatisgood
Copy link

image

I added some content on the example you provided. Turns out the root DOM would block it above.
I think the root DOM could be hidden in popup mode.

@alexgarces
Copy link
Owner

Hello @imrobinized. Thanks for reporting the issue but I'm not sure I understand it since I can't reproduce the problem. Where are you adding the blocked content exactly?
I'm not sure if this change could break other people setups...

@caaatisgood
Copy link
Author

Hi @alexgarces, here's the example. I added some contents to the example you provided to reproduce the case.
screenshot on my end:
image

@Jule-
Copy link

Jule- commented Sep 27, 2019

@alexgarces Indeed, in popup mode you still generate this empty div :

<div
   class="ReactTypeformEmbed"
   style="position: absolute; top: 100px; left: 0px; width: 100%; height: 100%; overflow: hidden;">
</div>

Since it is an absolute 100% width and height div it catches pointer events for the HTML elements right after it in the regular flow (cf. @imrobinized screenshot).

For what I have seen you don't even use it for the form popup so I think it cannot break anything to remove the width and height (at least) of this div.ReactTypeformEmbed in popup mode.
Removing them make a 0x0 div which is harmless for the user's DOM, IMHO.

@Jule-
Copy link

Jule- commented Sep 27, 2019

Btw @imrobinized an easy "dirty fix" :

<ReactTypeformEmbed popup ... style={{ width: 0, height: 0 }} />

@salvoravida
Copy link

same problem

@AlbertGozzi
Copy link

Btw @imrobinized an easy "dirty fix" :

<ReactTypeformEmbed popup ... style={{ width: 0, height: 0 }} />

Came for the same issue and this solved it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants