Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #11957] AuthModule add admin exist #12066

Merged
merged 9 commits into from
May 24, 2024

Conversation

godhth
Copy link
Contributor

@godhth godhth commented May 7, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#11957

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@godhth godhth requested a review from KomachiSion May 13, 2024 03:33
@godhth godhth requested a review from KomachiSion May 17, 2024 02:32
KomachiSion
KomachiSion previously approved these changes May 20, 2024
@KomachiSion
Copy link
Collaborator

There is some conflict with test file.

# Conflicts:
#	auth/src/test/java/com/alibaba/nacos/auth/config/AuthModuleStateBuilderTest.java
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 68.74%. Comparing base (6bee5c4) to head (efd14e2).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12066      +/-   ##
=============================================
- Coverage      68.77%   68.74%   -0.03%     
- Complexity      9127     9132       +5     
=============================================
  Files           1252     1252              
  Lines          40886    40907      +21     
  Branches        4340     4340              
=============================================
+ Hits           28119    28123       +4     
- Misses         10757    10773      +16     
- Partials        2010     2011       +1     
Files Coverage Δ
...m/alibaba/nacos/sys/module/ModuleStateBuilder.java 100.00% <100.00%> (ø)
...nacos/plugin/auth/impl/NacosAuthPluginService.java 0.00% <0.00%> (ø)
...acos/plugin/auth/spi/server/AuthPluginService.java 0.00% <0.00%> (ø)
...baba/nacos/auth/config/AuthModuleStateBuilder.java 88.88% <75.00%> (-11.12%) ⬇️
...os/plugin/auth/impl/controller/UserController.java 10.22% <0.00%> (+0.44%) ⬆️
...om/alibaba/nacos/sys/module/ModuleStateHolder.java 79.06% <50.00%> (-14.04%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bee5c4...efd14e2. Read the comment docs.

@KomachiSion KomachiSion added the kind/feature type/feature label May 24, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone May 24, 2024
@KomachiSion KomachiSion merged commit 992f10a into alibaba:develop May 24, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants