-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #11957] AuthModule add admin exist #12066
Conversation
auth/src/main/java/com/alibaba/nacos/auth/config/AuthModuleStateBuilder.java
Outdated
Show resolved
Hide resolved
auth/src/main/java/com/alibaba/nacos/auth/config/AuthConfigs.java
Outdated
Show resolved
Hide resolved
auth/src/main/java/com/alibaba/nacos/auth/config/AuthModuleStateBuilder.java
Outdated
Show resolved
Hide resolved
There is some conflict with test file. |
# Conflicts: # auth/src/test/java/com/alibaba/nacos/auth/config/AuthModuleStateBuilderTest.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12066 +/- ##
=============================================
- Coverage 68.77% 68.74% -0.03%
- Complexity 9127 9132 +5
=============================================
Files 1252 1252
Lines 40886 40907 +21
Branches 4340 4340
=============================================
+ Hits 28119 28123 +4
- Misses 10757 10773 +16
- Partials 2010 2011 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
#11957
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.