Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/bug fix config history rollback missing type #8800

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

chenhao26-nineteen
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

for #8799 ,添加type字段到历史记录表中,显示配置原始类型

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.21%. Comparing base (e97b695) to head (79f1bc6).
Report is 850 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8800      +/-   ##
=============================================
- Coverage      43.28%   43.21%   -0.08%     
  Complexity      4707     4707              
=============================================
  Files            904      904              
  Lines          32494    32494              
  Branches        3748     3748              
=============================================
- Hits           14066    14042      -24     
- Misses         17078    17100      +22     
- Partials        1350     1352       +2     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97b695...79f1bc6. Read the comment docs.

@stale
Copy link

stale bot commented Mar 25, 2023

Thanks for your feedback and contribution. But the issue/pull request has not had recent activity more than 180 days. This issue/pull request will be closed if no further activity occurs 7 days later.
We may solve this issue in new version. So can you upgrade to newest version and retry?
If there are still issues or want to contribute again. Please create new issue or pull request again.

@stale stale bot added the expired No active for a long time label Mar 25, 2023
@shiyiyue1102
Copy link
Collaborator

不兼容的改动,需要升级表结构,不建议当前版本合入,可以下一次大版本中再考虑

@shiyiyue1102 shiyiyue1102 added the Nacos3.0 Nacos 3.0 Architecture Evolution label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nacos3.0 Nacos 3.0 Architecture Evolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants