-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #9308]For the orchestration of configuration filters, there are the following areas that can be optimized #9309 #9310
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #9310 +/- ##
=============================================
+ Coverage 44.10% 44.12% +0.01%
- Complexity 4862 4866 +4
=============================================
Files 913 913
Lines 33052 33057 +5
Branches 3828 3828
=============================================
+ Hits 14579 14587 +8
- Misses 17052 17053 +1
+ Partials 1421 1417 -4
Continue to review full report at Codecov.
|
Can you discuss with communities first? |
Yes, I have already raised the corresponding issue, welcome to discuss together |
good |
1 Add FilterChainNode as the responsibility chain node to package the configuration filter, so each node contains the current configuration filter and the next responsibility chain node.
2 At startup, build a chain of responsibility through the buildConfigFilterChain() method.
3 Create EmptyFilterChainNode as the last node on the chain to reduce the next == null judgment during execution
1 新增FilterChainNode作为责任链节点,对配置过滤器进行包装,于是每个节点包含当前的配置过滤器,以及下一个责任链节点。
2 在启动时,通过buildConfigFilterChain()方法构建责任链。
3 创建EmptyFilterChainNode作为链上的最后一个节点,减少在执行过程中的 next == null 判断
issue