Conflicting statuses

[anthonyroux]

Reported by Feng

There are conflicting statuses:

I was following the process() function in Request.swift (see below), error says ("The request timed out."); the response says success (Status Code: 200,); data is nil. The three messages are not consistent, which causes a runtime error (Thread 8: Fatal error: Unexpectedly found nil while unwrapping an Optional value), when unwrapping "data".

private func process(request: NSMutableURLRequest,
                  onCompletion: @escaping AmadeusResponse) {
    let session = URLSession.shared
    let task = session.dataTask(with: request as URLRequest, completionHandler: { data, response, error in

        var amadeusResponse: Response?
        var amadeusError: ResponseError?

        if let httpResponse = response as? HTTPURLResponse {
            // got a valid HTTP answer
            amadeusResponse = Response(response: httpResponse, data: data!)
            // Error could be either nil (200 OK) or enum value
            amadeusError = amadeusResponse!.getErrorCode()
        } else {
            // no HTTP answer: network problem
            amadeusResponse = nil
            amadeusError = ResponseError.returnedError(error!)
        }
        onCompletion(amadeusResponse, amadeusError)
    })
    task.resume()
}```