Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests requiring geochemistry still run when compiling with --disable-geochemistry #248

Open
rfiorella opened this issue Mar 21, 2024 · 1 comment

Comments

@rfiorella
Copy link

A handful of regression tests (all the 07-* tests, and many of the 09-* tests) fail when using ctest against ATS binary built with --disable-geochemistry. Presumably these test failures are expected since these would be the tests requiring geochemistry, and so perhaps should be disabled when using --disable-geochemistry in bootstrap.

Occurs both building against master and rfiorella/elm_api (1.4) branches.

(Not sure if this repo or Amanzi is the right place for this issue - let me know if it should be moved).

@ecoon
Copy link
Collaborator

ecoon commented Mar 21, 2024

Yep, this is a fine place.

Fixing this requires two changes:

  1. In amanzi/ats-regression-tests, add a new testsuite for "testing_no_geochemistry" that omits the geochemistry tests.
  2. In ats's cmake, there is a call to python regression_tests.py --list-tests --suites=testing which generates the list of tests to add as ctest targets. This would need to be updated to get the right suite based on the boolean ENABLE_GEOCHEMISTRY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants