Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{%= path %} contains full structure, including cwd, when used with grunt-newer #58

Open
happycollision opened this issue Sep 27, 2014 · 3 comments
Open

{%= path %} contains full structure, including cwd, when used with grunt-newer #58

happycollision opened this issue Sep 27, 2014 · 3 comments
Labels
enhancement

Comments

@happycollision
Copy link

Using grunt-newer with grunt-responsive-images seems to override the {%= path %} used in custom_dest and includes the FULL path from the root of the project.
happycollision added a commit to happycollision/dondentonactor.com that referenced this issue Sep 28, 2014
@happycollision
Removes grunt-newer from gruntfile
2325e95 
It is still installed and required, but I am not using it until the bug
I referenced is fixed.

andismith/grunt-responsive-images#58
@andismith
Copy link
Owner

There have been a number of reported problems with Grunt:Newer and the responsive images plugin. You can use the newFilesOnly option instead of grunt:newer for the meantime.

See #57

@jayalfredprufrock
Copy link

Just noticed this as well. Somewhere around line 474 f.orig.cwd is passed to getDestination and is actually undefined. Oddly enough, the actual value can be found at f.orig.orig.cwd. Switching to newFilesOnly option produces expected result but I'd much prefer to use grunt-newer for consistency.

@andismith
Copy link
Owner

Can you change the line, and let me know if it's giving you the right results locally? If it seems to be, submit a pull request.

I'm happy to change the plugin, but need to make sure we don't break anything for everyone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayalfredprufrock @andismith @happycollision