Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skin does not work with Maven Site Plugin 3.5 #49

Open
bindul opened this issue Mar 1, 2016 · 10 comments
Open

Skin does not work with Maven Site Plugin 3.5 #49

bindul opened this issue Mar 1, 2016 · 10 comments

Comments

@bindul
Copy link

bindul commented Mar 1, 2016

The changes introduced in Maven Site Plugin breaks the skin. Maven Site 3.5 introduced some non backward compatible changes From 3.4 to 3.5

Among other issues, the body is rendered as:

<div class="body-content">
$bodyWithHeader
</div>
bindul added a commit to deventropy/deventropy-parent that referenced this issue Mar 1, 2016
Required till we move away from reflow-maven-skin or
andriusvelykis/reflow-maven-skin#49 is solved.

Change-Id: Ice54eb8c1dd0781c5a7039b9441e48ada6d5f7a3
@Bernardo-MG
Copy link

The root problem is that the new Maven Site plugin is not loading Velocity tools.

See:
http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html

@marvec
Copy link

marvec commented May 26, 2016

I am experiencing the same issue and a fix would be highly appreciated.

@Bernardo-MG
Copy link

As I've been completely unable to find a fix to this problem, and it seems everybody else is in the same situation, I've opened an issue for the Maven Site plugin:
https://issues.apache.org/jira/browse/MSITE-782

@michael-o
Copy link

This issue has been fixed in https://issues.apache.org/jira/browse/DOXIASITETOOLS-168 and needs some trivial changes in this plugin.

@Bernardo-MG
Copy link

Thanks for the fix

@solomax
Copy link

solomax commented Dec 8, 2016

Recently tried with Maven Site Plugin 3.6 and this issue is not fixed :(

@bindul
Copy link
Author

bindul commented Dec 8, 2016

@solomax, as noted above (by @michael-o):

This issue has been fixed in https://issues.apache.org/jira/browse/DOXIASITETOOLS-168 and needs some trivial changes in this plugin.

The plugin still needs a change, I believe around moving reflow-maven-skin/reflow-velocity-tools/src/main/resources/tools.xml to
META-INF/maven/site-tools.xml (or moving it there during the build), as suggested in DOXIASITETOOLS-168 comment-15578066.

Have not tested.

bindul added a commit to bindul/reflow-maven-skin that referenced this issue Dec 8, 2016
Allows the skin to be used when generating sites with maven-site-plugin
version 3.6 and higher.

- Add copy-rename-maven-plugin to create META-INF/maven/site-tools.xml
from src/resources/tools.xml see
[DOXIASITETOOLS-168](https://issues.apache.org/jira/browse/DOXIASITETOOLS-168?focusedCommentId=15578066&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15578066).
- Changes //body/head/* and //body/footer/* rendering. See [Maven Site
Plugin migration from 3.4 to
3.5.1](https://maven.apache.org/plugins/maven-site-plugin/migrate.html#From_3.4_to_3.5.1)

Resolves andriusvelykis#49
bindul added a commit to bindul/reflow-maven-skin that referenced this issue Dec 8, 2016
Allows the skin to be used when generating sites with maven-site-plugin
version 3.6 and higher.

- Add copy-rename-maven-plugin to create META-INF/maven/site-tools.xml
from src/resources/tools.xml see
[DOXIASITETOOLS-168](https://issues.apache.org/jira/browse/DOXIASITETOOLS-168?focusedCommentId=15578066&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15578066).
- Changes //body/head/* and //body/footer/* rendering. See [Maven Site
Plugin migration from 3.4 to
3.5.1](https://maven.apache.org/plugins/maven-site-plugin/migrate.html#From_3.4_to_3.5.1)

Resolves andriusvelykis#49
@Bernardo-MG
Copy link

I've updated my own skin for working with Maven Site 3.6: https://github.com/Bernardo-MG/docs-maven-skin

As commented, from now on any custom tool should move the tools.xml file to META-INF/maven/site-tools.xml

@Ordiel
Copy link

Ordiel commented Apr 22, 2019

Should we fork this project? @andriusvelykis does not seam to be active on this repo any more (for about 5 years now)

@solomax
Copy link

solomax commented Apr 22, 2019

@Ordiel we are using this one https://github.com/devacfr/reflow-maven-skin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants