Added CSS files for every Component with Styles #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmckni3
requested changes
Nov 1, 2017
cmckni3
reviewed
Nov 1, 2017
|
I appreciate the PR, @Aonepathan. Can you make the changes I have outlined? After that I will merge and update the build process. |
cmckni3
requested changes
Nov 1, 2017
|
@cmckni3 I've made the requested changes, please let me know if the :host pseudo-class should be included in the component.ts files. I went ahead with your recommendation to update host as the class name instead and inserted in the template as a div |
|
I see some issues with the CSS not being applied to components under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style properties have been extracted from every component and been placed in corresponding CSS files within the package.
Please let me know if this needs to be changed or was off the mark with the issue!
Closes #35