Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create OF_GOOD to distinguish high-level wearables #3486

Closed
angband-import opened this issue Jan 11, 2020 · 6 comments
Closed

Create OF_GOOD to distinguish high-level wearables #3486

angband-import opened this issue Jan 11, 2020 · 6 comments
Labels
R: fixed (in v4) Resolution: Fixed in v4 (only for v4, no longer current) T: enhancement Type: An improvement to the game
Milestone

Comments

@angband-import
Copy link
Collaborator

Reported by magnate on 23 Apr 2011 19:16 UTC
We've been struggling for years with the fact that a small number of armours and weapons are in a different class from most base items. These include DSMs, Blades of Chaos, Scythes of Slicing, Maces of Disruption, and Elven Cloaks.

The proposal is to give these items OF_GOOD in object.txt, enabling us to test for this flag elsewhere in the code (e.g. squelching).

@angband-import angband-import added T: enhancement Type: An improvement to the game M: Triage labels Jan 11, 2020
@angband-import angband-import added this to the Triage milestone Jan 11, 2020
@angband-import
Copy link
Collaborator Author

Modified by magnate on 13 Jun 2011 21:10 UTC

@angband-import angband-import modified the milestones: Triage, Future Jan 11, 2020
@angband-import
Copy link
Collaborator Author

Comment by magnate on 17 Jun 2011 19:09 UTC
This ticket also includes removing the hackish kind_is_good() in obj-make.c

@angband-import
Copy link
Collaborator Author

Comment by magnate on 7 Oct 2011 10:08 UTC
These are all done (or at least underway) in http://github.com/magnate/angband/tree/affixes.

@angband-import angband-import modified the milestones: Future, 3.4.0 Jan 11, 2020
@angband-import
Copy link
Collaborator Author

Comment by magnate on 13 Oct 2011 09:35 UTC
This ticket is addressed in (or enabled by) #94

@angband-import
Copy link
Collaborator Author

Comment by magnate on 21 Oct 2011 15:58 UTC
Initial assignment to v4 per http://trac.rephial.org/roadmap

@angband-import angband-import modified the milestones: 3.4.0, 4.0 Jan 11, 2020
@angband-import
Copy link
Collaborator Author

Comment by magnate on 22 Oct 2011 12:56 UTC
Fixed in the affixes merge [r48ccc16f]

@angband-import angband-import added the R: fixed (in v4) Resolution: Fixed in v4 (only for v4, no longer current) label Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R: fixed (in v4) Resolution: Fixed in v4 (only for v4, no longer current) T: enhancement Type: An improvement to the game
Projects
None yet
Development

No branches or pull requests

1 participant