Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace indices in function calls with pointers #3568

Open
angband-import opened this issue Jan 11, 2020 · 7 comments
Open

Replace indices in function calls with pointers #3568

angband-import opened this issue Jan 11, 2020 · 7 comments
Labels
T: enhancement Type: An improvement to the game
Milestone
Ongoing

Comments

@angband-import
Copy link
Collaborator

Reported by cunninggabe on 1 Aug 2011 12:31 UTC
For many functions, we pass around r_idx, and then right away get the monster race pointer from it. In such a case, we should just pass the pointer around instead. Same for item kinds, artifacts, etc.
@angband-import angband-import added T: enhancement Type: An improvement to the game M: 4.0 labels Jan 11, 2020
@angband-import angband-import added this to the 4.0 milestone Jan 11, 2020
@angband-import
Copy link
Collaborator Author

Comment by magnate on 13 Oct 2011 09:18 UTC
http://github.com/angband/angband/pull/88 for stage one.

@angband-import
Copy link
Collaborator Author

Comment by magnate on 23 Oct 2011 07:57 UTC
These are all underlying or uncontroversial issues, unconnected with the experimental nature of v4 - therefore re-setting to V milestone.

@angband-import angband-import modified the milestones: 4.0, 3.5.0 Jan 11, 2020
@angband-import
Copy link
Collaborator Author

Comment by magnate on 24 Oct 2011 20:14 UTC
Stage two (midx to m_ptr) was merged in [rceba01016]. Are there any more to do?

@angband-import
Copy link
Collaborator Author

Comment by takkaria on 25 Oct 2011 11:59 UTC
Loads!

@angband-import
Copy link
Collaborator Author

Comment by takkaria on 26 Jul 2013 17:14 UTC
Punting to post 3.5.

@angband-import angband-import modified the milestones: 3.5.0, Future Jan 11, 2020
@angband-import
Copy link
Collaborator Author

Comment by NickMcConnell on 21 Jan 2016 21:07 UTC
A lot of these have been done

@NickMcConnell
Copy link
Member

In fact, I think really this is an ongoing issue.

@NickMcConnell NickMcConnell modified the milestones: Future, Ongoing Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: enhancement Type: An improvement to the game
Projects
None yet
Milestone
Ongoing
Development

No branches or pull requests
2 participants
@NickMcConnell @angband-import