Remove bogus pvals

[angband-import]

Reported by magnate on 22 Sep 2011 13:00 UTC
Prior to lots of other object stuff (see [[Goals for 3.4]] but in particular #1039) we need to stop using pvals for stuff that isn't a pval flag. The three cases are:

food: I suggest a simple o_ptr->food value would suffice, though there are probably better solutions long-term

fuel: again, o_ptr->fuel suggests itself. In fact this could do for both fuel and food, unless we envisage some sort of elvish draught that would have one value when quaffed and another when poured into a lamp. Decrementing this value for in-use lights would probably be easier than using o_ptr->timeout.

gold: IMO this ought to be fixed by making o_ptr->number u16b and multiplying by sval to get the gp value

[angband-import]

Comment by magnate on 22 Sep 2011 13:02 UTC
Ooops. I forgot about case four: charges. ISTR discussion a while ago about moving to o_ptr->charges[] so that stacks of charged items remember their individual charges.

[angband-import]

Comment by takkaria on 22 Sep 2011 17:12 UTC
Moving to o_ptr->charges[] is really really difficult - it took me months to figure out how to do it, and that was independently of any other changes. The problem comes from the fact that the object management code is not set up to allow leak-free allocating and freeing of arrays within the object structs. It seems sensible for fuel/food/charges to all share the same field, though.

If number is u16b and we use that to store the GP value, why would multiplication be needed?

[angband-import]

Comment by magnate on 23 Sep 2011 07:57 UTC
I was envisaging o_ptr->number to be the number of coins, rather than the gp value. That's probably unnecessarily complicated though, and your way is better.

So in the first instance we move to o_ptr->fuel for light/food/charges, and charges remain munged together for a stack until we sort out the array-leakage ...

[angband-import]

Comment by takkaria on 23 Sep 2011 12:14 UTC
On a slightly pedantic and OT note, the game's exact wording is "ten gold pieces worth of silver" - it's a lump of metal rather than coins that the player picks up.

[angband-import]

Comment by magnate on 13 Oct 2011 09:35 UTC
This ticket is addressed in (or enabled by) #94

[angband-import]

Comment by magnate on 13 Oct 2011 13:45 UTC
This is done in http://github.com/angband/angband/pull/94

[angband-import]

Comment by magnate on 21 Oct 2011 15:58 UTC
Initial assignment to v4 per http://trac.rephial.org/roadmap

[angband-import]

Comment by magnate on 22 Oct 2011 12:56 UTC
Fixed in the affixes merge [r48ccc16f]