Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Upgrade Carousel to use the new $interval service. #1308

Closed
rgaskill opened this issue Nov 26, 2013 · 1 comment
Closed

Upgrade Carousel to use the new $interval service. #1308

rgaskill opened this issue Nov 26, 2013 · 1 comment
Labels
AngularJS 1.2

Comments

@rgaskill
Copy link

The $timeout polling causes angular/protractor tests to fail. As described here The $interval service was introduced in Angular 1.2.
@pkozlowski-opensource
Copy link
Member

Why not. We are going to look into it while working on the AngularJS 1.2 integration.

@chrisirhc chrisirhc mentioned this issue Jan 6, 2014
Closed
@rgaskill rgaskill mentioned this issue Feb 28, 2014
Closed
This was referenced Oct 27, 2014
Closed
Closed
OronNadiv pushed a commit to lanetix/bootstrap that referenced this issue Nov 18, 2014
@Gahen
fix(carousel): replaced $timeout with $interval when it was wrong
aa9fdee 
I had a to tweak a bit two tests since $interval never throws an exception after flushing, hope I did it OK.

Ammend: addresses @chrisirhc critics

Fixes angular-ui#1308
Fixes angular-ui#2454
Closes angular-ui#2776
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
AngularJS 1.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkozlowski-opensource @rgaskill