This repository has been archived by the owner on May 29, 2019. It is now read-only.
Use $interval instead of $timeout in the carousel implementation #2454
Labels
Comments
|
Hey guys! The PR I sent solves an important issue for those of us who are using protractor and this lib's carousel. As @juliemr said, protractor waits for all $timeout to finish, so with out the patch it hangs forever. There is no nice and simple workaround, I had to patch it and use my version to avoid this issue. |
|
I am running into the issue that @Gahen is mentioning. We just upgraded to the latest carousel and now our protractor tests are completely broken. I tried a few different approaches but so far they aren't working. This seems to be the same thing that has been an issue for almost a year now. See issue #1308. |
OronNadiv
pushed a commit
to lanetix/bootstrap
that referenced
this issue
Nov 18, 2014
I had a to tweak a bit two tests since $interval never throws an exception after flushing, hope I did it OK. Ammend: addresses @chrisirhc critics Fixes angular-ui#1308 Fixes angular-ui#2454 Closes angular-ui#2776
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Based on #1630 (comment)
The text was updated successfully, but these errors were encountered: