Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Popover adds a new scope every time it opens #2907

Closed
sdesmond opened this issue Oct 30, 2014 · 3 comments
Closed

Popover adds a new scope every time it opens #2907

sdesmond opened this issue Oct 30, 2014 · 3 comments

Comments

@sdesmond
Copy link
Contributor

Every time a popover displays, it adds a new scope to the mix. After a while, this causes things to slow down dramatically, especially when those popovers display a lot of data in an already large application. I've seen the behavior using Batarang.

When the popover is opened, a new child scope is created. When it is closed, the scope remains. When it is opened again, a new child scope is created which is identical to the first. When it is closed again, both scopes remain, etc. etc.

http://plnkr.co/edit/toUlHDz4hOlgJTCUv4EQ?p=preview

Transfer the code from Plunker to a local machine to see it in action (there are a lot of other scopes in Plunker and I don't see it happening there).

@ghost
Copy link

ghost commented Oct 30, 2014

Is it possible that the scopes don't get cleaned up only when Batarang is
open? I have heard that Batarang holds on to references to scopes.

On Thu Oct 30 2014 at 8:23:23 AM Spencer notifications@github.com wrote:

Every time a popover displays, it adds a new scope to the mix. After a
while, this causes things to slow down dramatically, especially when those
popovers display a lot of data in an already large application. I've seen
the behavior using Batarang.

When the popover is opened, a new child scope is created. When it is
closed, the scope remains. When it is opened again, a new child scope is
created which is identical to the first. When it is closed again, both
scopes remain, etc. etc.

http://plnkr.co/edit/toUlHDz4hOlgJTCUv4EQ?p=preview

Transfer the code from Plunker to a local machine to see it in action
(there are a lot of other scopes in Plunker and I don't see it happening
there).


Reply to this email directly or view it on GitHub
#2907.

@sdesmond
Copy link
Contributor Author

How would I be able to check that? Also, I've tested it with the Angular Strap version of Popover and I don't see the multiple scopes.

On Thu Oct 30 2014 at 11:29:31 AM redab notifications@github.com wrote:

Is it possible that the scopes don't get cleaned up only when Batarang is
open? I have heard that Batarang holds on to references to scopes.

On Thu Oct 30 2014 at 8:23:23 AM Spencer notifications@github.com
wrote:

Every time a popover displays, it adds a new scope to the mix. After a
while, this causes things to slow down dramatically, especially when
those
popovers display a lot of data in an already large application. I've
seen
the behavior using Batarang.

When the popover is opened, a new child scope is created. When it is
closed, the scope remains. When it is opened again, a new child scope is
created which is identical to the first. When it is closed again, both
scopes remain, etc. etc.

http://plnkr.co/edit/toUlHDz4hOlgJTCUv4EQ?p=preview

Transfer the code from Plunker to a local machine to see it in action
(there are a lot of other scopes in Plunker and I don't see it happening
there).


Reply to this email directly or view it on GitHub
#2907.


Reply to this email directly or view it on GitHub
#2907 (comment)
.

@chrisirhc
Copy link
Contributor

This will be fixed via #2919 . Closing this as duplicate of #2709 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants