Modal - can't close if using angular 1.4

[alippai]

You can't close modals with version 0.13. Angular-bootstrap 0.12 modal works well with angular 1.4.
Angular 1.3 + bootstrap 0.13 works too.

[rvanbaalen]

Plunker please.

[RobJacobs]

There is a known issue with Angular 1.4 and the Modal/Carousel directives. The ngAnimate module had some significant changes documented here that breaks how those directives are chaining animations. The area that needs to be addressed in the modal is here. As a workaround, I changed that line from:

domEl.one('$animate:close', function closeFn() {
    $rootScope.$evalAsync(afterAnimating);
}

To:

$rootScope.$evalAsync(afterAnimating);

You lose the closing animation. @chrisirhc is aware of the problem.

[rvanbaalen]

@RobJacobs What you're refering to is probably #3615 ?

@alippai specifically said he 'cant close modals' which would suggest that the modal always stays open after opening once. Thats why I asked for a plunkr reproducing this problem.

Reading this again, the issue is supposedly with AngularJS 1.4, which we don't currently support since it's still in beta.

If you're using UI Bootstrap, use 0.13 with Angular 1.3 and it's all good.

[alippai]

Only the backdrop didn't disappear, the dialog closed successfully. I couldn't create a plunker as the official demo worked with angular 1.4.

[rvanbaalen]

When you create a plunkr you can choose which library versions you want to use.

[alippai]

I referenced the correct versions, but couldn't reproduce the wrong behaviour.

[rvanbaalen]

That's when an issue gets closed 😉

[RobJacobs]

@alippai is correct, the modal will close, but the backdrop element does not get removed. Reason being the $animate api has changed on how to attach event handlers. It needs to be:

$animate.on(element, 'event', function() {})

So the afterAnimating function never gets called which is responsible from removing the backdrop element. Oddly enough, plunkr does not exhibit this behavior but I've been testing Angular 1.4 compatibility locally with the documentation page and that's how I noticed the problem.

[rvanbaalen]

Reopening. Related: #3624