Skip to content

Commit

Permalink
fix(Filtering): Let mobile devices tap filter box
Browse files Browse the repository at this point in the history
A preventDefault() in the filter input's ng-click was preventing mobile
users from being able to select the input box. Tapping on it simply did
nothing.

Removing this preventDefault() fixed the issue, and does not seem to have
caused any side effects.
  • Loading branch information
c0bra committed Dec 10, 2014
1 parent 43d6480 commit 01c22ac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/templates/ui-grid/uiGridHeaderCell.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
</div>

<div ng-if="filterable" class="ui-grid-filter-container" ng-repeat="colFilter in col.filters">
<input type="text" class="ui-grid-filter-input" ng-model="colFilter.term" ng-click="$event.stopPropagation()" ng-attr-placeholder="{{colFilter.placeholder || ''}}" />
<input type="text" class="ui-grid-filter-input" ng-model="colFilter.term" ng-attr-placeholder="{{colFilter.placeholder || ''}}" />

<div class="ui-grid-filter-button" ng-click="colFilter.term = null">
<i class="ui-grid-icon-cancel" ng-show="!!colFilter.term">&nbsp;</i> <!-- use !! because angular interprets 'f' as false -->
Expand Down

0 comments on commit 01c22ac

Please sign in to comment.