Skip to content

Commit

Permalink
fix(columnMoving): handle touch events properly when jQuery is used (#…
Browse files Browse the repository at this point in the history
…5666)

Fix(columnMoving): handle touch events properly when jQuery is used

Column moving on mobile devices would fail when jQuery is enabled. This change ensures that jQuery

touch events are handled correctly.

Issue #4400
  • Loading branch information
evmac authored and mportuga committed Sep 9, 2016
1 parent a08a3e3 commit a81e5d5
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/features/move-columns/js/column-movable.js
Expand Up @@ -324,7 +324,7 @@
gridLeft += $scope.grid.renderContainers.left.header[0].getBoundingClientRect().width;
}

previousMouseX = event.pageX;
previousMouseX = event.pageX || (event.originalEvent ? event.originalEvent.pageX : 0);
totalMouseMovement = 0;
rightMoveLimit = gridLeft + $scope.grid.getViewportWidth();

Expand All @@ -338,7 +338,8 @@
};

var moveFn = function( event ) {
var changeValue = event.pageX - previousMouseX;
var pageX = event.pageX || (event.originalEvent ? event.originalEvent.pageX : 0);
var changeValue = pageX - previousMouseX;
if ( changeValue === 0 ){ return; }
//Disable text selection in Chrome during column move
document.onselectstart = function() { return false; };
Expand All @@ -350,7 +351,7 @@
}
else if (elmCloned) {
moveElement(changeValue);
previousMouseX = event.pageX;
previousMouseX = pageX;
}
};

Expand Down

0 comments on commit a81e5d5

Please sign in to comment.