Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not correctly show column footer after async load option #2686

Closed
GoldyMark opened this issue Feb 1, 2015 · 5 comments
Closed

Not correctly show column footer after async load option #2686

GoldyMark opened this issue Feb 1, 2015 · 5 comments
Assignees
Milestone

Comments

@GoldyMark
Copy link

When I first time load data,the column footer showed correctly.

After that I loaded data from server,the column footer became narrow.

It might be css style problem?

plunker here:http://plnkr.co/edit/IpGd7R

@GoldyMark
Copy link
Author

Before async load:
qq20150201-1

After async load:
qq20150201-2

@PaulL1
Copy link
Contributor

PaulL1 commented Feb 2, 2015

@swalters, @c0bra: it looks to me like the change of the columnDefs (with columns of the same name) is resulting in all the columns getting new UIDs. The header and the body are changing to use the style with the new UID, the footer is still referring to the old styles.

I recall that both of you did some work in this area, @c0bra I think you most recently.

Updated plunker here: http://plnkr.co/edit/VH8fXDZEheLrUx85V5i4?p=preview (I tweaked the css so the header wasn't broken for me, and I changed it to push the new columns rather than replacing the columnDefs).

A hint towards the cause is this change: http://plnkr.co/edit/DkIyIb0GVFYXisnLdMXy?p=preview, in which I give all the columns new names each time, and everything works fine.

@PaulL1 PaulL1 added this to the 3.0 milestone Feb 2, 2015
@GoldyMark
Copy link
Author

But the column names should not be changed.

After remove numCalls or replace with "",the problem still.

Plunker here:http://plnkr.co/edit/usmnEY

@GoldyMark
Copy link
Author

Emm...I did a hack about this problem.

Plunker here:http://plnkr.co/edit/DkhcZD

@c0bra c0bra self-assigned this Apr 16, 2015
@c0bra
Copy link
Contributor

c0bra commented Apr 16, 2015

I believe this is because when you blow away your column defs the columns are changing their UIDs, which means the CSS class names change. The header was fixed in the last couple months to update their CSS class with a column defs change, but maybe the footer has not been fixed similarly.

I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants