New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding and removing columns toggle visible ruins the grid. #2789

Closed

mikila85 opened this issue Feb 17, 2015 · 1 comment

Assignees

Labels

Milestone

mikila85 commented Feb 17, 2015

reproduce:

go here: http://ui-grid.info/docs/#/tutorial/113_adding_and_removing_columns
press 4 times "Add"
press 1 time "Toggle Visible"
scroll down.

c0bra added the type: bug label

c0bra added this to the 3.0 milestone

c0bra self-assigned this

Contributor

c0bra commented Feb 18, 2015

Note to self: the problem is here: https://github.com/angular-ui/ng-grid/blob/fee00cdfa5aeaeb5a10db8ea71e64035eb39bba0/src/js/core/factories/Grid.js#L796

a & b here are GridColumn objects. This probably needs to be a.displayName.match and b.displayName.match.

Although... this works initially with the first few columns. So what happens with column number 4?

c0bra closed this as completed in

dd6dc15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment