Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

column moving and selection don't work together (RC21) #3417

Closed
AgDude opened this issue May 4, 2015 · 2 comments · Fixed by #3426
Closed

column moving and selection don't work together (RC21) #3417

AgDude opened this issue May 4, 2015 · 2 comments · Fixed by #3426
Milestone

Comments

@AgDude
Copy link
Contributor

AgDude commented May 4, 2015

Here is a plunker:
http://plnkr.co/edit/HIFDqPgfi2fftTV0ekrd?p=preview

The problem seems to be in src\features\move-columns\js\column-movable.js in the moveElement function. The newElementLeft is not calculated properly because the 'grid-render-container' now has a margin of 30px to leave space for the selection checkboxes.

@AgDude
Copy link
Contributor Author

AgDude commented May 4, 2015

It looks like this line:

gridLeft = $scope.grid.element[0].getBoundingClientRect().left;

Should change to:

$scope.grid.renderContainers.body.header[0].getBoundingClientRect()

Since it appears what we are really interested in is the offset of the column within the header. I don't have any experience with pinned containers, do those need special handling?

@AgDude
Copy link
Contributor Author

AgDude commented May 5, 2015

duplicate of #3395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants