Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Persian Translation. #3842

Closed
wants to merge 2 commits into from
Closed

Updating the Persian Translation. #3842

wants to merge 2 commits into from

Conversation

salarmehr
Copy link

Review on Reviewable

@JLLeitschuh
Copy link
Contributor

Travis's errors:

src/js/i18n/fa.js
  line 19  col 29  This character may get silently deleted by one or more browsers.
  line 21  col 23  This character may get silently deleted by one or more browsers.
  line 23  col 21  This character may get silently deleted by one or more browsers.
  line 24  col 25  This character may get silently deleted by one or more browsers.
  line 28  col 21  This character may get silently deleted by one or more browsers.
  line 36  col 22  This character may get silently deleted by one or more browsers.
  line 51  col 24  This character may get silently deleted by one or more browsers.
  line 53  col 44  This character may get silently deleted by one or more browsers.
  line 54  col 43  This character may get silently deleted by one or more browsers.
  line 55  col 44  This character may get silently deleted by one or more browsers.
  line 56  col 44  This character may get silently deleted by one or more browsers.
  line 57  col 43  This character may get silently deleted by one or more browsers.
  line 58  col 44  This character may get silently deleted by one or more browsers.
  line 62  col 63  This character may get silently deleted by one or more browsers.
  line 73  col 22  This character may get silently deleted by one or more browsers.
  line 74  col 28  This character may get silently deleted by one or more browsers.

These will need to be fixed before we can merge this.

@salarmehr
Copy link
Author

@JLLeitschuh They are notice indeed. The pointed characters are quit safe. The push can be merged safely.

@JLLeitschuh
Copy link
Contributor

The travis build failed however, you will need to figure out a way to get the build to pass before we can merge it in.

@c0bra
Copy link
Contributor

c0bra commented Jun 29, 2015

@salarmehr You could try saving the file as UTF-8 and running grunt jshint locally, or put /* jshint -W100 */ at the top of the file.

@salarmehr
Copy link
Author

@c0bra Merging all i18n files in the built file make it heavy. Please keep them separate. The developer can merge the needed language himself.

@c0bra
Copy link
Contributor

c0bra commented Jun 30, 2015

@salarmehr Sounds like a good suggestion. You can open a separate issue for that if you want.

Also your commit includes changes to pagination.html, which you probably didn't intend. Can you fix that, rebase, and push again? Thanks.

@salarmehr
Copy link
Author

@c0bra I'm not sure how do that. May you please shed some light on it? If possible please manually copy and paste the new fa.js file to your local repo and ignore the PRl.

@c0bra c0bra closed this in 2f2936a Jul 1, 2015
@c0bra
Copy link
Contributor

c0bra commented Jul 1, 2015

@salarmehr I went ahead and brought your changes in manually. Thanks for the commit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants