Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned columns are not included in export of visible data. #3888

Closed
anilnatha opened this issue Jun 29, 2015 · 6 comments
Closed

Pinned columns are not included in export of visible data. #3888

anilnatha opened this issue Jun 29, 2015 · 6 comments

Comments

@anilnatha
Copy link

I have encountered a bug when the "Export visible data to csv" option in the grid menu is chosen when the grid is using pinned columns. The problem is that if you have either the 'pinnedRight' or 'pinnedLeft' columndef options set, and choose the option 'Export visible data to csv" in the grid menu, the pinned columns will not be exported to CSV.

I tried the following to resolve the issue:

  1. Setting the 'visible' columndef option for the two columns to 'true', but the problem persisted.
  2. Setting the 'exporterSuppressExport' columndef option to false for the columns, but the problem persisted.

For both attempts listed above, I verified that this issue was due to the pinning properties, by removing the 'pinnedRight' and 'pinnedLeft' properties and sure enough, once removed, the columns exported just fine with the 'Export visible data to csv'

Based off the pinning tutorial, I created a plunker example showcasing the issue which you can view here.

I first noticed this issue on my development machine, which is running the following:

Windows 7 Enterprise
UI-Grid: v3.0.0-rc.22
Angular: 1.3.16
Browsers:

  1. Chrome (Version 43.0.2357.130 m)
  2. Firefox ESR (version 31.7) which is equivalent to Firefox 38

Notes:

  1. I have not tried the export of visible data to PDF, so it is entirely possible that this functionality may be working or may not be working with PDF exports.
  2. For the application I am working on, I have two pinned columns, one of which needs to be exported, the other will be suppressed, so it's important that even if a user chooses the 'export visible data' option, that both the ''exporterSuppressExport' columndef option or the 'exporterSuppressColumns' gridoption still continue to suppress columns as needed.
@lebolo
Copy link
Contributor

lebolo commented Jul 13, 2015

I've also encountered this bug during csv exporting.

Windows 7
Google Chrome 43.0.2357.132 m
UI Grid v3.0.0-rc.22
AngularJS 1.4.2

@PaulL1
Copy link
Contributor

PaulL1 commented Jul 13, 2015

I suspect the problem is that visible data is exported from the body container. It needs modifying to export left (if present), then body, then right (if present).

swalters added a commit that referenced this issue Aug 27, 2015
fix(export): Included pinned columns in export of visible data. Fixed issue #3888.
@sonphuong
Copy link

could you please tell me how to fix this? I need that

@JLLeitschuh
Copy link
Contributor

This should be taken care of in the most recent release (3.0.6). If its not please feel free to reopen.

@anilnatha
Copy link
Author

Thank you @JLLeitschuh for the status update and resolution. I'll try it out and report back in the coming days.

@anilnatha
Copy link
Author

My apologies for the delay. I've updated to version 3.1.1 in my app and I can confirm that I can now export visible data for pinned columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants