Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uigrid (in cellnav.js) always just request focus when the directive uiGridViewport is constructed #3896

Closed
jcompagner opened this issue Jun 30, 2015 · 1 comment

Comments

@jcompagner
Copy link
Contributor

ui-grid is just one of the components on our page (could even be more then 1 ui-grid)
but we do call focus() on a certain element, but the focus is then most of the times (depends on timing) suddenly transferred .
Its then on the div with the class "ui-grid-focuser" this is because in cellnav.js on line 851 there is always a focus request call: uiGridCtrl.focus();

ui grid should not do that by default when it is constructed, only when it somehow already had focus or focus was request to it by the developer itself.

Now the focus is really forced to it when loading (and for me at that time the grid is even not filled its empty)

@JLLeitschuh
Copy link
Contributor

I found this bug myself while working through adding screen reader accessibility to cell nav.
It is caused by this line here: https://github.com/angular-ui/ng-grid/blob/e9a6d4eba67dba23c42b54b23054c048cf9d8ebc/src/features/cellnav/js/cellnav.js#L851

I was planning on fixing it in my accessibility push.

@JLLeitschuh JLLeitschuh self-assigned this Jun 30, 2015
JLLeitschuh added a commit that referenced this issue Jul 20, 2015
As you navigate the grid using cell nav the browser should now read out
the cell that is currently focused.

Fixes #3896
Partially resolves #3815
JLLeitschuh added a commit to JLLeitschuh/ui-grid that referenced this issue Jul 20, 2015
As you navigate the grid using cell nav the browser should now read out
the cell that is currently focused.

Fixes angular-ui#3896
Partially angular-ui#3815
JLLeitschuh added a commit to JLLeitschuh/ui-grid that referenced this issue Jul 22, 2015
As you navigate the grid using cell nav the browser should now read out
the cell that is currently focused.

Fixes angular-ui#3896
Partially angular-ui#3815
JLLeitschuh added a commit to JLLeitschuh/ui-grid that referenced this issue Jul 27, 2015
As you navigate the grid using cell nav the browser should now read out
the cell that is currently focused.

Fixes angular-ui#3896
Partially angular-ui#3815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants