If column/grid menu is wider than 170px, or padding is greater than 10px, the menu is shifted when it is first opened. #6587
Comments
caseyjhol
added a commit
to snapappointments/ui-grid
that referenced
this issue
Mar 3, 2018
Since v3.0.0-rc.21, the column/grid menu animation slides down from above the grid, but it is visible the entire time. This causes the animation to appear clunky. This has been resolved by setting `overflow: hidden` on the menu. Fixes angular-ui#3436, angular-ui#3921, angular-ui#3978. Showing/hiding the menu can seem slow. The menu animation has been sped up as well, and when it is hidden, the animation is now twice as fast. Previously, to calculate the menu position, the width of the menu needed to be calculated, which meant calling `repositionMenu` twice - once when first opening the menu, and again after the menu is visible to allow the width of the menu to be determined. This also meant there was always a "shift" when the menu was first opened (as a default width of 170px was used until the actual width of the menu could be determined. This implements the CSS trick `right: 100%` so the width is not needed when determining the menu's position, meaning the menu can be opened much more smoothly and without needing to call `repositionMenu` twice. Fixes angular-ui#6587.
caseyjhol
added a commit
to snapappointments/ui-grid
that referenced
this issue
Mar 3, 2018
Since v3.0.0-rc.21, the column/grid menu animation slides down from above the grid, but it is visible the entire time. This causes the animation to appear clunky. This has been resolved by setting `overflow: hidden` on the menu. Fixes angular-ui#3436, angular-ui#3921, angular-ui#3978. Showing/hiding the menu can seem slow. The menu animation has been sped up as well, and when it is hidden, the animation is now twice as fast. Previously, to calculate the menu position, the width of the menu needed to be calculated, which meant calling `repositionMenu` twice - once when first opening the menu, and again after the menu is visible to allow the width of the menu to be determined. This also meant there was always a "shift" when the menu was first opened (as a default width of 170px was used until the actual width of the menu could be determined. This implements the CSS trick `right: 100%` so the width is not needed when determining the menu's position, meaning the menu can be opened much more smoothly and without needing to call `repositionMenu` twice. Fixes angular-ui#6587. remove lastMenuWidth from tests
caseyjhol
added a commit
to snapappointments/ui-grid
that referenced
this issue
Mar 3, 2018
Since v3.0.0-rc.21, the column/grid menu animation slides down from above the grid, but it is visible the entire time. This causes the animation to appear clunky. This has been resolved by setting `overflow: hidden` on the menu. Fixes angular-ui#3436, angular-ui#3921, angular-ui#3978. Showing/hiding the menu can seem slow. The menu animation has been sped up as well, and when it is hidden, the animation is now twice as fast. Previously, to calculate the menu position, the width of the menu needed to be calculated, which meant calling `repositionMenu` twice - once when first opening the menu, and again after the menu is visible to allow the width of the menu to be determined. This also meant there was always a "shift" when the menu was first opened (as a default width of 170px was used until the actual width of the menu could be determined. This implements the CSS trick `right: 100%` so the width is not needed when determining the menu's position, meaning the menu can be opened much more smoothly and without needing to call `repositionMenu` twice. Fixes angular-ui#6587. remove lastMenuWidth from tests no message
mportuga
pushed a commit
that referenced
this issue
Mar 5, 2018
Since v3.0.0-rc.21, the column/grid menu animation slides down from above the grid, but it is visible the entire time. This causes the animation to appear clunky. This has been resolved by setting `overflow: hidden` on the menu. Fixes #3436, #3921, #3978. Showing/hiding the menu can seem slow. The menu animation has been sped up as well, and when it is hidden, the animation is now twice as fast. Previously, to calculate the menu position, the width of the menu needed to be calculated, which meant calling `repositionMenu` twice - once when first opening the menu, and again after the menu is visible to allow the width of the menu to be determined. This also meant there was always a "shift" when the menu was first opened (as a default width of 170px was used until the actual width of the menu could be determined. This implements the CSS trick `right: 100%` so the width is not needed when determining the menu's position, meaning the menu can be opened much more smoothly and without needing to call `repositionMenu` twice. Fixes #6587. remove lastMenuWidth from tests no message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See an example here: https://plnkr.co/edit/Sr45hW2zhXcbPxvzEBTB?p=preview.
Open a column menu - it is initially positioned incorrectly.
I've increased the width of the menu (as well as the padding) to exaggerate the issue. Internally, repositionMenu is called again and then the menu is positioned correctly. Subsequent menu opens are positioned correctly.
Will submit a PR shortly with a fix.
The text was updated successfully, but these errors were encountered: