This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Feat component publisher #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned - add livereload on the builded gh-page - fix the existing watch task
- boss : "Use '!==' to compare with 'null'" - globalstrict : "Missing 'use strict' statement"
I have no idea of what it supposed to do. I fixed it by returning the value given in the function argument but I bet that it's not the behavior we want -_-
I guess that we want angular.isArray here
Must be a typo
- fix(mask): ReferenceError: c is not defined - fix(indeterminate): ReferenceError: assignment to undeclared variable elm
The sub components don't have to be recreated every time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brace yourself a component publisher is coming !