Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADEV: do not show "On this page" section if there is only 1 item available #54236

Closed
AndrewKushnir opened this issue Feb 3, 2024 · 4 comments
Closed

ADEV: do not show "On this page" section if there is only 1 item available #54236

AndrewKushnir opened this issue Feb 3, 2024 · 4 comments
Labels
area: docs-infra Angular.dev application and infrastructure state: has PR
Milestone
needsTriage

Comments

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Feb 3, 2024 •
edited

For example, see https://angular.dev/errors/NG0507 - it contains only 1 section and the "On this page" block looks redundant. The proposal is to update the code to show "On this page" if there is more than one item in that list.
@AndrewKushnir AndrewKushnir added the area: docs-infra Angular.dev application and infrastructure label Feb 3, 2024
@ngbot ngbot bot added this to the needsTriage milestone Feb 3, 2024
JeanMeche added a commit to JeanMeche/dev-infra that referenced this issue Feb 22, 2024
@JeanMeche
refactor(shared-docs): Hide TOC if there is only 1 item.
fa6059d 
fixes #angular/angular#54236
@JeanMeche JeanMeche mentioned this issue Feb 22, 2024
Closed
@JeanMeche
Copy link
Member

PR is open on the dev-infra repo.

@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Feb 22, 2024 •
edited

Thanks @JeanMeche!

josephperrott pushed a commit to angular/dev-infra that referenced this issue Feb 26, 2024
@JeanMeche @josephperrott
refactor(shared-docs): Hide TOC if there is only 1 item. (#1801)
659c76b 
fixes #angular/angular#54236

PR Close #1801
@twerske
Copy link
Contributor

twerske commented Mar 27, 2024

Closed by the linked PR!

@twerske twerske closed this as completed Mar 27, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: docs-infra Angular.dev application and infrastructure state: has PR
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

refactor(shared-docs): Hide TOC if there is only 1 item. JeanMeche/dev-infra
3 participants
@JeanMeche @twerske @AndrewKushnir