New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some typos throughout the codebase #55018
Conversation
The commit message is modeled after #52249 (review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. 👍
@ranma42 Can you adjust the commit message? The linter is failing. Please see the contributing guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
|
@sonukapoor as I mentioned in #55018 (comment) it looks like the conventions have recently changed. What is the preferred approach? Should I split the commit so that there I can assign a scope to each change? (there seems to be no "catch-all" scope) |
@ranma42 I think the title is fine. It's the body of the commit message. It's required and has to be at least 20 characters. |
Fix some typos detected using spellchecking tools, both in documentation and in code (comments, identifiers).
ah, I see! sorry I had misunderstood the lint feedback and thought that the issue was that the title did not have the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Disabling pullapprove -- we don't need that many approvals for typo fixes. Also merging into main only, due to patch branch conflicts. |
This PR was merged into the repository by commit f3b6245. |
Fix some typos detected using spellchecking tools, both in documentation and in code (comments, identifiers). PR Close angular#55018
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Fixes to simple typos.
What is the current behavior?
Some of the code comments and docs have typos.
Issue Number: N/A
What is the new behavior?
A few less typos.
Does this PR introduce a breaking change?
Other information