Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos throughout the codebase #55018

Closed
wants to merge 1 commit into from
Closed

Conversation

ranma42
Copy link
Contributor

@ranma42 ranma42 commented Mar 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:
    Fixes to simple typos.

What is the current behavior?

Some of the code comments and docs have typos.

Issue Number: N/A

What is the new behavior?

A few less typos.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ranma42
Copy link
Contributor Author

ranma42 commented Mar 24, 2024

The commit message is modeled after #52249 (review)
and #52826 🤔

Copy link
Contributor

@sonukapoor sonukapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. 👍

@sonukapoor
Copy link
Contributor

sonukapoor commented Mar 24, 2024

@ranma42 Can you adjust the commit message? The linter is failing. Please see the contributing guidelines:

https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit

✘ Invalid commit message
refactor: fix a number of typos throughout the codebase
Error:
The commit message body does not meet the minimum length of 20 characters

The expected format for a commit is:
():

@ranma42
Copy link
Contributor Author

ranma42 commented Mar 24, 2024

@sonukapoor as I mentioned in #55018 (comment) it looks like the conventions have recently changed. What is the preferred approach? Should I split the commit so that there I can assign a scope to each change? (there seems to be no "catch-all" scope)

@sonukapoor
Copy link
Contributor

@ranma42 I think the title is fine. It's the body of the commit message. It's required and has to be at least 20 characters.

Fix some typos detected using spellchecking tools, both in
documentation and in code (comments, identifiers).
@ranma42
Copy link
Contributor Author

ranma42 commented Mar 25, 2024

ah, I see! sorry I had misunderstood the lint feedback and thought that the issue was that the title did not have the (): format.
It looks like the linter likes the new commit message 🥳
Thank you @sonukapoor !

Copy link
Contributor

@sonukapoor sonukapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Copy link
Contributor

@JiaLiPassion JiaLiPassion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bencodezen bencodezen added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Mar 25, 2024
@ranma42 ranma42 changed the title Fix some of typos throughout the codebase Fix some typos throughout the codebase Mar 26, 2024
@dylhunn dylhunn added the area: core Issues related to the framework runtime label Mar 27, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 27, 2024
@dylhunn dylhunn added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 27, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Mar 27, 2024

Disabling pullapprove -- we don't need that many approvals for typo fixes. Also merging into main only, due to patch branch conflicts.

@dylhunn
Copy link
Contributor

dylhunn commented Mar 27, 2024

This PR was merged into the repository by commit f3b6245.

@dylhunn dylhunn closed this in f3b6245 Mar 27, 2024
ilirbeqirii pushed a commit to ilirbeqirii/angular that referenced this pull request Apr 6, 2024
Fix some typos detected using spellchecking tools, both in
documentation and in code (comments, identifiers).

PR Close angular#55018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2024
@ranma42 ranma42 deleted the fix/typos branch April 27, 2024 06:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime PullApprove: disable target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants