fix(forms): Make reactive form directives standalone #55321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
detected: breaking change
jermowery
force-pushed
the
reactive-forms-standalone
branch
from
7877d37
to
83358ec
Compare
Add `standalone: true` to the reactive forms directives BREAKING CHANGE: Breaks any people declaring these directives (like in tests) Users will need to move these directives from declarations to imports in their tests if they are broken Fixes angular#55320
jermowery
force-pushed
the
reactive-forms-standalone
branch
from
83358ec
to
5867ea4
Compare
|
Hi, I'm going to copy @dylhunn's answer from #48616
For this reason, this feature cannot land without a major redesign of the forms. Thanks for your contributions anyway, any suggestion is welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
standalone: trueto the reactive forms directivesBREAKING CHANGE: Breaks any people declaring these directives (like in tests)
Users will need to move these directives from declarations to imports in their tests if they are broken
Fixes #55320
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Reactive forms components are not standalone
Issue Number: #55320
What is the new behavior?
The components are standalone
Does this PR introduce a breaking change?
Code which declares the reactive forms directives will break because the components are now standalone.
Users will need to switch from declaring these directives to importing them.
Other information