Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(forms): replace errors with hasError() #55379

Closed
wants to merge 1 commit into from
Closed

refactor(forms): replace errors with hasError() #55379

wants to merge 1 commit into from

Conversation

ice-blaze
Copy link
Contributor

Material documentation use hasError. For homogeneity reason, this commit will adopt material style.

Fixes #55378

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #55378

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from dylhunn April 17, 2024 11:04
@ice-blaze
Copy link
Contributor Author

ice-blaze commented Apr 17, 2024 •
edited

The material discussion about using hasError instead of errors angular/components#28884 (comment)
The issue related to it angular/components#28883

@ice-blaze
refactor(forms): replace errors with hasError()
b50e040 
Material documentation use hasError. For homogeneity reason, this commit
will adopt material style.

Fixes angular#55378
@ice-blaze ice-blaze force-pushed the refactor/change-errors-into-haserror branch from aba78af to b50e040 Compare April 17, 2024 11:12
@pkozlowski-opensource pkozlowski-opensource added the area: adev Angular.dev documentation label Apr 17, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 17, 2024
JeanMeche
JeanMeche approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement !

sonukapoor
sonukapoor approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@sonukapoor sonukapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree hasError is a better approach. 👍

@bencodezen bencodezen added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Apr 24, 2024
@AndrewKushnir AndrewKushnir removed the request for review from dylhunn April 25, 2024 15:56
@AndrewKushnir AndrewKushnir added target: rc This PR is targeted for the next release-candidate and removed target: minor This PR is targeted for the next minor release labels Apr 25, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit e54c950.

AndrewKushnir pushed a commit that referenced this pull request Apr 25, 2024
@ice-blaze @AndrewKushnir
refactor(forms): replace errors with hasError() (#55379)
5ad2f5f 
Material documentation use hasError. For homogeneity reason, this commit
will adopt material style.

Fixes #55378

PR Close #55379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonukapoor sonukapoor sonukapoor approved these changes

@JeanMeche JeanMeche JeanMeche approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: adev Angular.dev documentation target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Use hadError instead of errors
6 participants
@ice-blaze @AndrewKushnir @sonukapoor @JeanMeche @pkozlowski-opensource @bencodezen