fix(core): resolve error for multiple component instances that use fallback content #55478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
action: review
crisbeto
force-pushed
the
55466/fallback-content-multiple
branch
from
dda6daf
to
221ab52
Compare
AndrewKushnir
approved these changes
Apr 24, 2024
…llback content Currently fallback content for `ng-content` gets declared and rendered out in one go. This breaks down if multiple instances of the same component are used where one doesn't render the fallback content while the other one does, because the `TNode` for the content has to be created during the first creation pass. These changes resolve the issue by always _declaring_ the template, but only rendering it if the slot is empty. Fixes angular#55466.
crisbeto
force-pushed
the
55466/fallback-content-multiple
branch
from
221ab52
to
d1c63d4
Compare
crisbeto
added
action: merge
AndrewKushnir
added
target: rc
|
This PR was merged into the repository by commit 97eea8d. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Apr 25, 2024
…llback content (#55478) Currently fallback content for `ng-content` gets declared and rendered out in one go. This breaks down if multiple instances of the same component are used where one doesn't render the fallback content while the other one does, because the `TNode` for the content has to be created during the first creation pass. These changes resolve the issue by always _declaring_ the template, but only rendering it if the slot is empty. Fixes #55466. PR Close #55478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fallback content for
ng-contentgets declared and rendered out in one go. This breaks down if multiple instances of the same component are used where one doesn't render the fallback content while the other one does, because theTNodefor the content has to be created during the first creation pass.These changes resolve the issue by always declaring the template, but only rendering it if the slot is empty.
Fixes #55466.