Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Error in datatype for the "City" field in "sign-up as admin". #889

Open
3 tasks
khatryshikha opened this issue Dec 11, 2018 · 23 comments · May be fixed by #1087
Open
3 tasks

Error in datatype for the "City" field in "sign-up as admin". #889

khatryshikha opened this issue Dec 11, 2018 · 23 comments · May be fixed by #1087
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Open Source Hack

Comments

@khatryshikha
Copy link

khatryshikha commented Dec 11, 2018

Description

While signing up as an admin then City i.e is "string" is typecasted as int somewhere in the code.

Mocks

screenshot from 2018-12-09 23-58-44

Acceptance Criteria

Update [Required]

  • Datatype correction in code

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

0.5 hours

@Monal5031
Copy link
Contributor

It's a valid issue 👍
@khatryshikha Have you found out the exact line of error?

@Monal5031 Monal5031 added Status: Available Issue was approved and available to claim or abandoned for over 3 days. Difficulty: EASY Category: Coding Changes to code base or refactored code that doesn't fix a bug. labels Dec 11, 2018
@khatryshikha
Copy link
Author

khatryshikha commented Dec 11, 2018

@Monal5031, yes I am working on it. Will make the PR as soon as possible.

@cristomathew
Copy link

is the issue solved? if not can i take it up

@Monal5031
Copy link
Contributor

Monal5031 commented Mar 7, 2020

There is a PR for this issue if @khatryshikha isn't working on it then sure you can @cristomathew

@Niharika-Arora
Copy link
Contributor

Hi! I'd like to work on this issue.

@kjain0073
Copy link

Hi, I'd love to work on this issue!

@Monal5031
Copy link
Contributor

@cristomathew do you still want to work on this issue or should I assign it to someone else?

@BeKingsman
Copy link

@Monal5031 Hi, i would like work on this issue.

@BeKingsman BeKingsman mentioned this issue Mar 15, 2020
5 tasks
@BeKingsman
Copy link

@Monal5031 Sorry i requested a PR without the issue being assigned to me. Can i fix this issue ?

@Aimaanhasan
Copy link

Hello, I'd like to work on this issue, Can I fix it?

@Monal5031
Copy link
Contributor

Sorry @Aimaanhasan @BeKingsman asked before you :(

@Monal5031 Monal5031 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 18, 2020
@BeKingsman BeKingsman mentioned this issue Mar 18, 2020
4 tasks
@BeKingsman
Copy link

@Monal5031 I have linked a pull request which will fix this issue.

@theyashshahs theyashshahs added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 8, 2020
@sanchibansal340 sanchibansal340 added Open Source Hack Status: Available Issue was approved and available to claim or abandoned for over 3 days. and removed Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Aug 28, 2020
@alivabasa
Copy link

I want to work on this as part of OSH

@heyanurag
Copy link

Is this issue available to work on? I am a First Time Contributor.

@sanchibansal340
Copy link

@alivabasa assigning this to you.

@alivabasa
Copy link

alivabasa commented Sep 2, 2020

@sanchibansal340 Thanks a lot ! Since I am a beginner , I m having a doubt whether the file is this or not. Plz guide me
vms/registration/templates/registration/signup_administrator.html or it is views.py file

@sanchibansal340 sanchibansal340 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Sep 2, 2020
@sanchibansal340
Copy link

@sanchibansal340 Thanks a lot ! Since I am a beginner , I m having a doubt whether the file is this or not. Plz guide me
vms/registration/templates/registration/signup_administrator.html or it is views.py file

@alivabasa Were you able to find the file?

@alivabasa
Copy link

alivabasa commented Sep 3, 2020

yes, just submitting.

alivabasa referenced this issue in alivabasa/vms Sep 3, 2020
Changed the data type for city in line 105 from "pk" to "name"
@alivabasa alivabasa linked a pull request Sep 3, 2020 that will close this issue
3 tasks
@alivabasa
Copy link

@sanchibansal340 plz review and tell me if any changes is required.

@sanchibansal340
Copy link

Will check @alivabasa

@rpattath
Copy link
Member

Is this issue a duplicate of #1002 ?

@devkapilbansal
Copy link
Member

Is this issue a duplicate of #1002 ?

@rpattath Yes, I mentioned it in respective pull requests too

@devkapilbansal
Copy link
Member

@rpattath the issue is already solved in another pull request. Therefore, Should the issue and linked pull request be closed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.