Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Deploy to Heroku and write instructions on how to do that #1135

Open
3 tasks
isabelcosta opened this issue Sep 27, 2020 · 12 comments · May be fixed by #1159 or #1160
Open
3 tasks

Deploy to Heroku and write instructions on how to do that #1135

isabelcosta opened this issue Sep 27, 2020 · 12 comments · May be fixed by #1159 or #1160
Assignees
@DARK-art108
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: Documentation/Training Improvements or additions to documentation.

Comments

@isabelcosta
Copy link
Member

Description

We want this project to be deployable in Heroku, how anitab-org/mentorship-backend is.

This will be useful to:

  • uses Review Apps on Heroku (e.g.: testers can use this without setting up the project)
  • the organization can use Heroku as a temporary solution if we cant use AWS

Feel free to discuss anything with the community about this issue and ask for help on #vms stream in our Zulip.

Acceptance Criteria

  • Deploy the app to Heroku
  • Write a markdown file with instructions on how to deploy this to Heroku
  • Submit any PR with additional changes needed to deploy the app
@isabelcosta isabelcosta added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: Documentation/Training Improvements or additions to documentation. Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Sep 27, 2020
@Aju100
Copy link

Aju100 commented Oct 2, 2020

@isabelcosta can u please assign me this

@Nishantkumarr
Copy link

Could you please assign me this task? I have experience in handling deployment on Heroku. Thank you.

@ashwinijha6
Copy link
Contributor

@isabelcosta I would like to work on this could u pls assign this to me

@isabelcosta
Copy link
Member Author

I assigned to you @Aju100 since you asked first :)
cc @ashwinijha6 @Nishantkumarr

@isabelcosta isabelcosta removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Oct 4, 2020
@Aju100
Copy link

Aju100 commented Oct 4, 2020

@isabelcosta thank u

@Aju100
Copy link

Aju100 commented Oct 7, 2020

@isabelcosta May I know which branch should be deployed in Heroku? Is it a master or AWS branch? I have deployed the master branch. Let me know which branch should be deployed? Thank you

@isabelcosta
Copy link
Member Author

@Aju100 it should be the develop branch which is the default one that we merge new PRs to :)

@DARK-art108
Copy link

Hello @isabelcosta can I take up this issue as I don't see any progress?

@isabelcosta
Copy link
Member Author

@Aju100 I will unassign from you and assign back to @DARK-art108 as there are no updates on your end (present in our contributing guidelines).

@darecoder I'll assign it to you.

@isabelcosta isabelcosta assigned DARK-art108 and unassigned Aju100 Oct 27, 2020
@DARK-art108
Copy link

Hello @isabelcosta I have deployed the web app to Heroku and here is the link to the deployment https://vms-r.herokuapp.com/
working on the markdown file will raise the PR in 2-3 days.

@DARK-art108 DARK-art108 linked a pull request Oct 27, 2020 that will close this issue
Open
6 tasks
@DARK-art108
Copy link

@isabelcosta raised the PR, review it

@DARK-art108 DARK-art108 linked a pull request Oct 28, 2020 that will close this issue
Open
6 tasks
@DARK-art108
Copy link

@isabelcosta raised the latest PR with the suggested changes.

Latest PR: #1160 please review it.
Previous PR: You can close that PR #1159 as I have made the changes suggested by you in the current PR #1160

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DARK-art108 DARK-art108

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: Documentation/Training Improvements or additions to documentation.
Projects
None yet
Milestone
No milestone
5 participants
@isabelcosta @Aju100 @ashwinijha6 @Nishantkumarr @DARK-art108