-
Notifications
You must be signed in to change notification settings - Fork 4
UI: Enhanced date selection by adding range of date selection #1119
base: develop
Are you sure you want to change the base?
Conversation
Need to edit some test cases , I will check this! |
So this error is occuring due to date format , should I change all date format in test cases . Becuase I tried to change update date format in datepicker and its not working. it is working for m/d/Y format only. Need some help @satya7289 . |
1 failure solved 2 errors still remaining working on it |
3171adf
to
93ee3de
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1119 +/- ##
==========================================
Coverage ? 87.14%
==========================================
Files ? 85
Lines ? 4060
Branches ? 237
==========================================
Hits ? 3538
Misses ? 452
Partials ? 70 Continue to review full report at Codecov.
|
Solved please review |
@SanketDG Hey @Kajol-Kumari please review |
@decon-harsh Thank you very much for your hard work. @SanketDG @satya7289 can you please review it as Codewise it's looking good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some test cases to validate that the dates are in a range in between the start date of the event and the end date of the event.
93ee3de
to
fb73196
Compare
fb73196
to
b495c0c
Compare
Added please verify @satya7289 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thank you for adding the test case for this.
Added maxDate and minDate in js function.
Deleted activate ActivateDatepicker function.
Added placeholders of end date and start date input tags.
Fixes #655
Type of Change:
Code/Quality Assurance Only
Mocks
Test
How Has This Been Tested?
Manually
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only