Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

UI: Enhanced date selection by adding range of date selection #1119

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

decon-harsh
Copy link
Member

@decon-harsh decon-harsh commented Sep 15, 2020

Added maxDate and minDate in js function.
Deleted activate ActivateDatepicker function.
Added placeholders of end date and start date input tags.

Fixes #655

Type of Change:

  • Quality Assurance
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

Mocks

first
two
third
fourth

Test

Screenshot from 2020-09-25 20-47-45

How Has This Been Tested?

Manually

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings

@decon-harsh
Copy link
Member Author

Need to edit some test cases , I will check this!

@decon-harsh
Copy link
Member Author

So this error is occuring due to date format ,

should I change all date format in test cases . Becuase I tried to change update date format in datepicker and its not working. it is working for m/d/Y format only.

Need some help @satya7289 .

@decon-harsh
Copy link
Member Author

1 failure solved 2 errors still remaining working on it

@decon-harsh decon-harsh force-pushed the Issue_655 branch 2 times, most recently from 3171adf to 93ee3de Compare September 16, 2020 05:26
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@b58bc98). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1119   +/-   ##
==========================================
  Coverage           ?   87.14%           
==========================================
  Files              ?       85           
  Lines              ?     4060           
  Branches           ?      237           
==========================================
  Hits               ?     3538           
  Misses             ?      452           
  Partials           ?       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b58bc98...b495c0c. Read the comment docs.

@decon-harsh
Copy link
Member Author

Solved please review

@decon-harsh
Copy link
Member Author

decon-harsh commented Sep 20, 2020

@SanketDG Hey @Kajol-Kumari please review

@Kajol-Kumari
Copy link

@decon-harsh Thank you very much for your hard work. @SanketDG @satya7289 can you please review it as Codewise it's looking good to me.

Copy link
Contributor

@satya7289 satya7289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test cases to validate that the dates are in a range in between the start date of the event and the end date of the event.

@decon-harsh
Copy link
Member Author

Please add some test cases to validate that the dates are in a range in between the start date of the event and the end date of the event.

Added please verify @satya7289

Copy link
Contributor

@satya7289 satya7289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thank you for adding the test case for this.

@satya7289 satya7289 added the Status: Needs Review PR needs an additional review or a maintainer's review. label Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The user must only be able to select dates that fall during the Event while creation of jobs
3 participants