Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx-build configuration is not being catched #3034

Closed
germa89 opened this issue Apr 26, 2024 · 0 comments · Fixed by #3035
Closed

sphinx-build configuration is not being catched #3034

germa89 opened this issue Apr 26, 2024 · 0 comments · Fixed by #3035
Assignees

Comments

@germa89
Copy link
Collaborator

germa89 commented Apr 26, 2024

As the title.

This has been discovered when updating sphinx to 7.3. See #3030
The PR sphinx-doc/sphinx#12203 introduced a warning that raises when the configuration is not pickable, aka cacheable.

Our sphinx_gallery_conf depends on module objects, hence it cannot be pickable.

This is not a big issue, as it can easily omitted: sphinx-doc/sphinx#12300 (comment)

And that is the recommended approach, since removing module objects from our configuration can take some time, and shows not much benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant