Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the multicastInterfaces option #3898

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Conversation

tnqn
Copy link
Member

@tnqn tnqn commented Jun 15, 2022

Some distros have exposed the multicastInterfaces option and made it
uncommented in the config file. antrea-agent would crash if a cluster
upgrades to v1.7.0 but doesn't remove the option. This patch adds the
option back and deprecates it in a compatible manner.

Signed-off-by: Quan Tian qtian@vmware.com

Some distros have exposed the multicastInterfaces option and made it
uncommented in the config file. antrea-agent would crash if a cluster
upgrades to v1.7.0 but doesn't remove the option. This patch adds the
option back and deprecates it in a compatible manner.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn requested review from liu4480 and jianjuns June 15, 2022 04:33
@tnqn tnqn marked this pull request as ready for review June 15, 2022 04:33
@liu4480
Copy link
Contributor

liu4480 commented Jun 15, 2022

LGTM

@tnqn
Copy link
Member Author

tnqn commented Jun 15, 2022

/skip-all
/test-multicast-e2e

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #3898 (3e6624d) into main (59fc30a) will increase coverage by 20.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3898       +/-   ##
===========================================
+ Coverage   35.16%   55.86%   +20.69%     
===========================================
  Files         122      415      +293     
  Lines       17123    60347    +43224     
===========================================
+ Hits         6022    33712    +27690     
- Misses      10602    23899    +13297     
- Partials      499     2736     +2237     
Flag Coverage Δ
integration-tests 35.14% <ø> (-0.03%) ⬇️
kind-e2e-tests 50.50% <ø> (?)
unit-tests 44.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/agent/cniserver/interface_configuration_linux.go 25.06% <0.00%> (-0.99%) ⬇️
...luster/controllers/multicluster/node_controller.go 65.59% <0.00%> (ø)
pkg/antctl/raw/traceflow/command.go 23.58% <0.00%> (ø)
pkg/controller/certificatesigningrequest/common.go 64.58% <0.00%> (ø)
pkg/agent/ipassigner/responder/ndp_responder.go 71.32% <0.00%> (ø)
pkg/agent/nodeportlocal/portcache/port_table.go 67.50% <0.00%> (ø)
pkg/ovs/openflow/ofctrl_bridge.go 56.86% <0.00%> (ø)
pkg/agent/config/ipsec_authentication_mode.go 53.84% <0.00%> (ø)
pkg/antctl/command_message.go 37.03% <0.00%> (ø)
pkg/controller/networkpolicy/mutate.go 66.95% <0.00%> (ø)
... and 284 more

@tnqn tnqn merged commit 5519d9e into antrea-io:main Jun 15, 2022
@tnqn tnqn deleted the deprecate-option branch June 15, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants