New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] DateMilliseconds is not always decoded correcly #40718
Comments
Looks like these lines should be |
Yes that works for me! thanks |
domoritz
added a commit
to domoritz/arrow
that referenced
this issue
Mar 21, 2024
Fix in #40725 and I added a simple test. |
kou
changed the title
in arrow.js, DateMilliseconds is not always decoded correcly
[JS] DateMilliseconds is not always decoded correcly
Mar 21, 2024
domoritz
added a commit
to domoritz/arrow
that referenced
this issue
Mar 22, 2024
domoritz
added a commit
to domoritz/arrow
that referenced
this issue
Mar 22, 2024
domoritz
added a commit
that referenced
this issue
Mar 22, 2024
Fixed in #40725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Doing a round-trip with a JavaScript Date in apache-arrow/js sometimes results in wrong values:
this prints:
As you can see there is a difference of 45 days. If I go and modify factories.ts and change
dtypes.DateMillisecond
todtypes.Float64
(line 122), the decoding returns the correct number.version information:
The results are correct for dates after epoch, but testing with
new Date(1969, 11, 31);
exhibits the problem.Component(s)
JavaScript
The text was updated successfully, but these errors were encountered: