Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI Environment Setup for Node.js 6 #438

Merged
merged 3 commits into from Apr 8, 2019

Conversation

GedasGa
Copy link
Contributor

@GedasGa GedasGa commented Apr 1, 2019

Platforms affected

All

Motivation and Context

Node.js 4 is officially out of active LTS. However, it was still used node.js 4 in the Travis CI and AppVeyor. This causes some builds to fail.

Description

Update Travis CI and AppVeyor configuration files to use node.js 6. Also, update the iOS platform to use xcode9 and android to use build-tools-28.0.2, because in the paramedic we already use newer versions.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu force-pushed the update-test-env branch 9 times, most recently from a8888e0 to 2c1ad29 Compare April 8, 2019 04:49
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@erisu erisu changed the title Update test environments to use node.js 6 Update CI Environment Setup for Node.js 6 Apr 8, 2019
@erisu erisu merged commit fae190e into apache:master Apr 8, 2019
@GedasGa GedasGa deleted the update-test-env branch April 9, 2019 02:53
chintan13 added a commit to logisticinfotech/cordova-plugin-camera that referenced this pull request Sep 30, 2019
* commit 'a9436b1a185b37269366ec3e2c5f337fb14cba61':
  ImagePicker returning same image (apache#306)
  chore(release): 4.1.1-dev
  chore(release): 4.1.0 (version string)
  chore(release): release notes for 4.1.0
  docs: remove outdated test docs translations
  build: remove `.ratignore` file that is not needed any more
  chore: fix repo and issue urls and license in package.json and plugin.xml
  fix: temporarily remove Appium tests (apache#468)
  ci(travis): Update Travis CI configuration for new paramedic (apache#455)
  (Android) Fix NullPointerException error on some Android phones (apache#429)
  Update CI Environment Setup for Node.js 6 (apache#438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants