Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

CSS optimizations are conservative in the presence of extra attributes #104

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

What is the expected output?   All CSS combined or cache-extended
What do you see instead?  Some CSS files are left unoptimized
What version of the product are you using:  X-Mod-Pagespeed 0.9.8.1-215
Which version of Apache?  Apache/2.2.3 (CentOS),  X-Powered-By  PHP/5.1.6
Please provide any additional information below, especially a URL or an
HTML file that exhibits the problem.

http://www.cloudtech.org/

These links are not optimized because mod_pagespeed ignores any 'link' tags 
with unexpected attributes.  It should just leave them alone -- actually 
CSS-combining should probably *not* combine CSS links with distinct IDs.  
However that should not prevent cache extension.

<link rel='stylesheet' id='codecolorer-css' 
href='http://www.cloudtech.org/wp-content/plugins/codecolorer/codecolorer.css?ve
r=0.9.8' type='text/css' media='screen'/>
<link rel='stylesheet' id='wp_dlmp_styles-css' 
href='http://www.cloudtech.org/wp-content/plugins/download-monitor/page-addon/st
yles.css?ver=3.0.1' type='text/css' media='all'/>

Original issue reported on code.google.com by jmara...@google.com on 20 Nov 2010 at 1:50

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 20 Nov 2010 at 1:51

  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

Same observed with charset="" attribute.

Original comment by webmas...@clubsilver.org on 10 Apr 2011 at 9:59

@GoogleCodeExporter
Copy link
Author

The restriction for combine_css still remains, but combine_css and rewrite_css 
no longer are affected by extra 'link' attributes.

Original comment by jmara...@google.com on 6 May 2011 at 2:38

  • Changed state: Fixed
  • Added labels: release-note

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant