Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

meta refresh tags within NOSCRIPT tags get converted to HTTP headers even when javascript is enabled #372

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Enabled convert_meta_tags filter (enabled by default)
2. Include this HTML in page X:
<noscript>
        <meta http-equiv="refresh" content="0;url=/PleaseEnableJavascript">
</noscript>
3. Fetch the page with mod_pagespeed enabled.

What is the expected output? What do you see instead?

If javascript is enabled in my browser, I expect to see my page X.  Instead
I get redirected to PleaseEnableJavscript.

mod_pagespeed is converting the meta refresh to an HTTP header in all cases (is 
ignoring the fact that the meta refresh occurs within a NOSCRIPT tag).


What version of the product are you using (please check X-Mod-Pagespeed
header)?

0.10.19.5-1253


On what operating system?

Linux.

Which version of Apache?

2.2.14


Which MPM?

Prefork.


Original issue reported on code.google.com by ja...@peaceworks.ca on 23 Jan 2012 at 6:34

@GoogleCodeExporter
Copy link
Author

Thanks for the report.

A work-around until we fix this is:

ModPagespeedDisableFilters convert_meta_tags

Original comment by sligocki@google.com on 23 Jan 2012 at 6:42

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Original comment by nfor...@google.com on 23 Jan 2012 at 6:42

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

This should be fixed in change 1353 (and part in 1352).

Please give it a shot when you have a chance and let me know if it works for 
you.  Thanks!

Original comment by nfor...@google.com on 24 Jan 2012 at 4:47

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by matterb...@google.com on 26 Jan 2012 at 3:07

  • Added labels: release-note

@GoogleCodeExporter
Copy link
Author

FYI: I have limited resources so won't be able to test the change until it is 
included in a new release.

Original comment by ja...@peaceworks.ca on 26 Jan 2012 at 3:10

@GoogleCodeExporter
Copy link
Author

Thanks Jason ... ANY help in testing it is much appreciated!

Original comment by matterb...@google.com on 26 Jan 2012 at 3:27

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant