Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

InitializeNested in CssHierarchy initializes a stringpiece with too wide a scope #601

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

The url_ variable scoped to CssHierarchy in Initalizenested is sometimes 
initialized with a stack scoped string (See calling functions to confirm this) 
If the stack scoped string is destroyed the url_ points to invalid data, this 
may or may not cause a crash in further processing.

Fix: make url_ a GoogleString, GoogleUrl or initialize a secondary variable.

Original issue reported on code.google.com by kspoels...@we-amp.com on 7 Jan 2013 at 9:05

@GoogleCodeExporter
Copy link
Author

Good catch.  Did you find this via valgrind or something?

Original comment by jmara...@google.com on 7 Jan 2013 at 9:12

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

No, :(, a css file was not loaded in the tests, a lot of old fashioned tracing 
and debugging followed ...

Original comment by kspoels...@we-amp.com on 9 Jan 2013 at 6:15

@GoogleCodeExporter
Copy link
Author

This is fixed in r2452. Are you able to build from source and try again?
Thanks!

Original comment by matterb...@google.com on 30 Jan 2013 at 5:43

  • Changed state: Fixed
  • Added labels: Milestone-v25

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant