Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

ModPagespeedRewriteRandomDropPercentage cause duplicate image srcs to be blank. #748

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

Input HTML: <img src='a.png'> <img src='a.png'>
Output HTML: <img src='a.png'> <img src=''>

This can occur when RewriteRandomDropPercentage is set to something greater 
than zero and images have duplicate URLs in the same HTML document.  The later 
images have their URLs removed.

Original issue reported on code.google.com by jkar...@google.com on 24 Jul 2013 at 2:38

@GoogleCodeExporter
Copy link
Author

The problem was that RewriteContext::RepeatedSuccess did not pass the kTooBusy 
bit (was_too_busy_) from the primary context to the next in line, so the next 
in line rendered the empty URL.

Original comment by jkar...@google.com on 24 Jul 2013 at 4:47

@GoogleCodeExporter
Copy link
Author

Note that this means that it's also a bug for load shedding.

Original comment by jkar...@google.com on 24 Jul 2013 at 4:47

@GoogleCodeExporter
Copy link
Author

Original comment by jkar...@google.com on 24 Jul 2013 at 5:18

  • Added labels: Milestone-v29, release-note

@GoogleCodeExporter
Copy link
Author

Original comment by jkar...@google.com on 24 Jul 2013 at 5:46

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

1.6.29.5-beta was just released and we believe it will resolve the issue.  
Thanks for filing a bug report!

Josh

Original comment by jkar...@google.com on 25 Jul 2013 at 3:16

@GoogleCodeExporter
Copy link
Author

Thankyou - I have implemented the latest beta version and the issue is indeed 
fixed.

Original comment by rwap.services on 26 Jul 2013 at 8:12

@GoogleCodeExporter
Copy link
Author

Original comment by jkar...@google.com on 26 Jul 2013 at 10:43

  • Changed state: Verified

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant