Add sub query explanations in DisjunctionMaxQuery#explain on no-match #13362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if it's a match or not.
timgrein
changed the title
timgrein
changed the title
timgrein
changed the title
|
This could make explanations harder to read for large queries, e.g. queries produced through rewriting. I wonder about doing something in-between such as only including the non-matching subs if the query doesn't match, what do you think? |
…query didn't match
Fair point! Adjusted the PR accordingly and added an additional test for the in-between behavior. |
tteofili
approved these changes
May 14, 2024
jpountz
approved these changes
May 14, 2024
|
Thanks for the reviews! Added it to the improvement section ✅ @jpountz |
jpountz
pushed a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13357
Description
#13357 states that it's useful to have the explanations of the sub queries of
DisjuncationMaxQuerypresent, even if the document didn't match. Considering that other queries likeCoveringQueryalso include explanations, if the document didn't match I've adjusted the logic according to the issue's proposal.Also added tests for
explain(match and no match case). I've also adjustedCheckHits#verifyExplanationto only check sub explanations, if the overall explanation returned a hit and scores need to be checked.