Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Dejavu URL #56

Open
geraldclark opened this issue Mar 6, 2018 · 3 comments
Open

Custom Dejavu URL #56

geraldclark opened this issue Mar 6, 2018 · 3 comments

Comments

@geraldclark
Copy link

Is there a recommended approach for updating the dejuvu "Data View" url to a local docker instance of dejavu?

@siddharthlatest
Copy link
Member

@geraldclark You should be able to change this in the source, and then build a custom docker image to do this.

The specific place you would need to change this is here -

viewData() {
.

I am not sure if it make sense for us to add this in the code as it may hurt accessibility in case a user doesn't have the other plugin installed locally.

@geraldclark
Copy link
Author

@siddharthlatest I was just thinking it might be beneficial to allow for an external configuration as I'd prefer to not have to build a custom docker image or modify the core app source.

@siddharthlatest
Copy link
Member

siddharthlatest commented Mar 6, 2018

That's a good idea. We would probably want to support some level of configurability (via env variables), but I am not sure atm what other things may be useful to go in. That said, I am happy to accept a PR for this specific configuration to get us started on that path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants