Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] - Tabs add - New tab like UI #33116

Closed
albinAppsmith opened this issue May 2, 2024 · 0 comments · Fixed by #33228
Closed

[Task] - Tabs add - New tab like UI #33116

albinAppsmith opened this issue May 2, 2024 · 0 comments · Fixed by #33228
Assignees
@albinAppsmith
Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching New Developers Pod Issues that new developers face while exploring the IDE Task A simple Todo

Comments

@albinAppsmith
Copy link
Collaborator

albinAppsmith commented May 2, 2024 •
edited

Instead of using an active toggle button for tabs add, render it as an active tab once the dd button is clicked.
@albinAppsmith albinAppsmith added the New Developers Pod Issues that new developers face while exploring the IDE label May 2, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label May 2, 2024
@github-actions github-actions bot removed the New Developers Pod Issues that new developers face while exploring the IDE label May 2, 2024
@albinAppsmith albinAppsmith added the IDE Navigation Issues/feature requests related to IDE navigation, and context switching label May 2, 2024
@github-actions github-actions bot added the New Developers Pod Issues that new developers face while exploring the IDE label May 2, 2024
@albinAppsmith albinAppsmith self-assigned this May 2, 2024
@albinAppsmith albinAppsmith mentioned this issue May 7, 2024
Merged
2 tasks
albinAppsmith added a commit that referenced this issue May 15, 2024
@albinAppsmith
feat: New tab ui changes (#33228)
f13309e 
## Description

Added new design of New Query/Js tab design.


Fixes #33116

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9084312304>
> Commit: 48223f4
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9084312304&attempt=2"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->
































## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albinAppsmith albinAppsmith

Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching New Developers Pod Issues that new developers face while exploring the IDE Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: New tab ui changes appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @albinAppsmith