Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): add pipeline average time metrics #3845

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(metrics): add pipeline average time metrics #3845

wants to merge 1 commit into from

Conversation

NDStrahilevitz
Copy link
Collaborator

1. Explain what the PR does

4aed8fc feat(metrics): add pipeline average time metrics

    Add two prometheus gauges measuring the following metrics:
    1. Average time spent from kernel to decoding
    2. Average time spent from kernel to publishing

2. Explain how to test it

  1. tracee --metrics
  2. Enter localhost:3366/metrics
  3. Check the pipeline metrics

3. Other comments

Resolve #3844

@NDStrahilevitz NDStrahilevitz self-assigned this Feb 4, 2024
geyslan
geyslan reviewed Feb 5, 2024
View reviewed changes
pkg/utils/time.go Show resolved Hide resolved
pkg/ebpf/events_pipeline.go Outdated Show resolved Hide resolved
pkg/metrics/stats.go Show resolved Hide resolved
@geyslan
Copy link
Member

geyslan commented Feb 21, 2024

We have this update #3875

Please rebase your PR against main to make use of the new workflow setup.

@geyslan
Copy link
Member

geyslan commented Apr 3, 2024

@NDStrahilevitz I'm not able to run the github actions on this. If it's ready for review, could you rebase it again? Tks.

@NDStrahilevitz
feat(metrics): add pipeline average time metrics
9b070ca 
Add two prometheus gauges measuring the following metrics:
1. Average time spent from kernel to decoding
2. Average time spent from kernel to publishing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geyslan geyslan geyslan left review comments

@yanivagman yanivagman Awaiting requested review from yanivagman

At least 1 approving review is required to merge this pull request.

Assignees

@NDStrahilevitz NDStrahilevitz

Labels
area/ebpf area/flags area/performance area/UX kind/feature milestone/v0.22.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event time in pipeline metrics
2 participants
@NDStrahilevitz @geyslan