Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support eurodate format (dd-mmm-yy with a digit month) #139

Open
dferstay opened this issue Nov 10, 2021 · 2 comments · Fixed by marcandjulien/dateparse#1 · May be fixed by #140 or #159
Open

Support eurodate format (dd-mmm-yy with a digit month) #139

dferstay opened this issue Nov 10, 2021 · 2 comments · Fixed by marcandjulien/dateparse#1 · May be fixed by #140 or #159

Comments

@dferstay
Copy link

dferstay commented Nov 10, 2021 •
edited

We have support for dates of the form dd-mmm-yy where mmm is an alphanumeric literal; for example:

"15-Jan-2017"

However, there is a European date format that is similar where mmm is a digit; for example:

"15-01-2017"

The above fails to parse with:

Could not find format for "28-02-02"
dferstay pushed a commit to dferstay/dateparse that referenced this issue Nov 10, 2021
Add support for dd-mm-yyyy (digit month) formats
65e246a 
Some European dates are formatted as dd-mm-yyyy where
day month and year are all digits.

Fixes araddon#139

Signed-off-by: Daniel Ferstay <dferstay@splunk.com>
@dferstay dferstay linked a pull request Nov 10, 2021 that will close this issue
Open
@twitchyliquid64
Copy link

What about teh sillyeh peoplez that put the month first? Its unambiguous if its the 13th day of the month, but otherwise what?

@dferstay
Copy link
Author

What about teh sillyeh peoplez that put the month first? Its unambiguous if its the 13th day of the month, but otherwise what?

I'm thinking that this is the same as dd/mm/yyyy vs mm/dd/yyyy, which is discussed near the very top of the README.md

MM/DD/YYYY VS DD/MM/YYYY Right now this uses mm/dd/yyyy WHEN ambiguous if this is not desired behavior, use ParseStrict which will fail on ambiguous date strings.

@hartfordfive hartfordfive mentioned this issue Jan 6, 2022
Closed
@marcandjulien marcandjulien mentioned this issue May 23, 2023
Merged
klondikedragon added a commit to itlightning/dateparse that referenced this issue Dec 13, 2023
@klondikedragon
Incorporate support for dd-mm-yyyy (digit month)
5fabfad 
Incorporate PR araddon#140 from
https://github.com/dferstay to fix
araddon#139

PR is adapted to avoid duplicate code and validate format
klondikedragon added a commit to itlightning/dateparse that referenced this issue Dec 13, 2023
@klondikedragon
Incorporate support for dd-mm-yyyy (digit month)
fc278d3 
Incorporate PR araddon#140 from
https://github.com/dferstay to fix
araddon#139

This also fixes araddon#155
(duplicate of issue 139)

PR is adapted to avoid duplicate code and validate format.
@klondikedragon klondikedragon linked a pull request Dec 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@twitchyliquid64 @dferstay