You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think many are aware of archive.append(null, { name:'dir/' }), but since it's not documented it's hard for a newcomer to find out about it. Also, since the docs for .append(source, data) regard source as Buffer | Stream | String, it feels quite like going against the grain with null.
On this note, what do you think about adding some more explicit functions for this i.e. appendFile and appendDirectory that simply proxy to append?
I'd be happy to work on PRs for both of these if needed!
The text was updated successfully, but these errors were encountered:
joelmukuthu
changed the title
Document how to append a directory
Document how to .append() a directory
Jan 14, 2023
I think many are aware of
archive.append(null, { name:'dir/' })
, but since it's not documented it's hard for a newcomer to find out about it. Also, since the docs for.append(source, data)
regardsource
asBuffer | Stream | String
, it feels quite like going against the grain withnull
.On this note, what do you think about adding some more explicit functions for this i.e.
appendFile
andappendDirectory
that simply proxy toappend
?I'd be happy to work on PRs for both of these if needed!
The text was updated successfully, but these errors were encountered: