Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error with time-picker when allowInput is true #2576

Merged
merged 1 commit into from May 23, 2024
Merged

fix: error with time-picker when allowInput is true #2576

merged 1 commit into from May 23, 2024

Conversation

zeezo887
Copy link
Collaborator

@zeezo887 zeezo887 commented May 2, 2024

Description

The error occurs because the parseDate function cannot return a valid date for a time string e.g 12:00 AM. The change introduced in this PR appends the time to the current date string so that the function can return a valid date.

if (self.isValidTime(date)) {
  const currentDate = new Date();
  date = `${currentDate.toDateString()} ${date}`;
}

Related Issues

Fixes #2557

@ifox ifox merged commit fbb7144 into area17:3.x May 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifox ifox ifox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time picker js error when allowInput is true
2 participants
@zeezo887 @ifox